Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: add rule to download and set swagger and make rule to build rekor-cli for cross platform #391

Merged
merged 2 commits into from
Jul 28, 2021
Merged

makefile: add rule to download and set swagger and make rule to build rekor-cli for cross platform #391

merged 2 commits into from
Jul 28, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 27, 2021

  • this adds a way to automatically download the swagger in the specific version we care and don't mess with go modules for the project.
  • also add rule to cross build rekor-cli for other linux/darwin/windows

bobcallaway
bobcallaway reviewed Jul 27, 2021
View reviewed changes
scripts/go_install.sh Outdated Show resolved Hide resolved
lukehinds
lukehinds approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with @bobcallaway review nit fixed)

@cpanato
makefile: add rule to download and set swagger and make rule to build…
b4c65f9 
… rekor-cli for cross platform

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato cpanato requested a review from bobcallaway July 27, 2021 15:59
@bobcallaway
Copy link
Member

how does this affect GitHub actions CI to ensure it is building with the same swagger version as defined in the Makefile?

@cpanato
Copy link
Member Author

cpanato commented Jul 27, 2021

@bobcallaway forgot CI, i will check, but ci will use this one we define in the makefile

@cpanato
update ci
97e49d4 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Jul 27, 2021

@bobcallaway updated CI

@lukehinds lukehinds merged commit 70eed2f into sigstore:main Jul 28, 2021
@cpanato cpanato deleted the release branch July 28, 2021 08:08
@cpanato cpanato mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcallaway bobcallaway bobcallaway approved these changes

@lukehinds lukehinds lukehinds approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpanato @bobcallaway @lukehinds